Fix indexes caching issue #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(ma2): indexes caching
Test indexes caching fix (ma2)
fix(mc): indexes caching
MathisGD
requested review from
Rubilmax,
QGarchery,
Tristan22400,
MerlinEgalite,
julien-devatom and
makcandrov
MerlinEgalite
approved these changes
Jun 6, 2023
julien-devatom
approved these changes
Jun 7, 2023
Rubilmax
approved these changes
Jun 7, 2023
Closed
Tristan22400
approved these changes
Jun 7, 2023
QGarchery
approved these changes
Jun 7, 2023
|
can be merged IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the index caching issue, on both AaveV2 and Compound Optimizers. The fix consists on recomputing the indexes each time (even if there has been an interaction with Morpho in the same block).