Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/oracle #2

Merged
merged 11 commits into from
Jul 10, 2021
Merged

Fix/oracle #2

merged 11 commits into from
Jul 10, 2021

Conversation

MathisGD
Copy link
Collaborator

@MathisGD MathisGD commented Jul 9, 2021

Fixes #1

@MathisGD
Copy link
Collaborator Author

MathisGD commented Jul 9, 2021

In c5679be, I don't see the "adaptation to oracle"

@MathisGD
Copy link
Collaborator Author

MathisGD commented Jul 9, 2021

8b375c3 can quickly and easily be squashed with 548fe0e, for better readability (liiiiiittle detail)

@MerlinEgalite
Copy link
Contributor

In c5679be, I don't see the "adaptation to oracle"

this is for testing. Since ETH price is the real one you need more DAI as collateral to borrow ETH

@MerlinEgalite
Copy link
Contributor

8b375c3 can quickly and easily be squashed with 548fe0e, for better readability (liiiiiittle detail)

have been squashed ✅

@MerlinEgalite MerlinEgalite merged commit e3a430f into main Jul 10, 2021
@MathisGD
Copy link
Collaborator Author

Nice job

@MerlinEgalite MerlinEgalite deleted the fix/oracle branch August 1, 2021 14:02
MerlinEgalite added a commit that referenced this pull request Jun 13, 2022
MerlinEgalite added a commit that referenced this pull request Aug 12, 2022
MathisGD added a commit that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix oracle everywhere (to get token prices)
2 participants