Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullable context for extensions generated via T4 #982

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

atifaziz
Copy link
Member

@atifaziz atifaziz commented Mar 8, 2023

This PR fixes #981 by enabling nullable context for the following extensions:

  • ToDelimitedString
  • Aggregate
  • Fold
  • Cartesian

Affects:

- ToDelimitedString
- Aggregate
- Fold
- Cartesian
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #982 (391395b) into master (b99a6a8) will not change coverage.
The diff coverage is n/a.

❗ Current head 391395b differs from pull request most recent head 06102d7. Consider uploading reports for the commit 06102d7 to get more accurate results

@@           Coverage Diff           @@
##           master     #982   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files         113      113           
  Lines        3434     3434           
  Branches     1052     1052           
=======================================
  Hits         3180     3180           
  Misses        191      191           
  Partials       63       63           
Impacted Files Coverage Δ
MoreLinq/Aggregate.g.cs 100.00% <ø> (ø)
MoreLinq/Cartesian.g.cs 62.11% <ø> (ø)
MoreLinq/Fold.g.cs 100.00% <ø> (ø)
MoreLinq/ToDelimitedString.g.cs 62.85% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit 06102d7 into morelinq:master Mar 8, 2023
@atifaziz atifaziz deleted the fix/981-tt-null-annotations branch March 8, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some generated extensions are missing nullable annotations
1 participant