Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some generated extensions are missing nullable annotations #981

Closed
atifaziz opened this issue Mar 8, 2023 · 0 comments · Fixed by #982
Closed

Some generated extensions are missing nullable annotations #981

atifaziz opened this issue Mar 8, 2023 · 0 comments · Fixed by #982
Assignees
Labels
Milestone

Comments

@atifaziz
Copy link
Member

atifaziz commented Mar 8, 2023

The following method overloads and implementations that are generated via T4 templates are missing nullable annotations even though the entire project has the nullable context enabled:

  • ToDelimitedString
  • Aggregate
  • Fold
  • Cartesian

This happens because of the following (documented) quirk:

Older code generation strategies may not be nullable aware. Setting the project-level nullable context to "enable" could result in many warnings that a user is unable to fix. To support this scenario any syntax tree that is determined to be generated will have its nullable state implicitly set to "disable", regardless of the overall project state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant