-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting code to Use C# 8 Nullable Reference Types #713
Conversation
853e288
to
3fd2d2a
Compare
3fd2d2a
to
6c08614
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moh-hassan, @Orace Thanks a lot for you help with this. Since this PR builds on PR #582, it would have been best to make your additions via another PR on the respective branch in my fork. Otherwise, it becomes very difficult & time-consuming to review here (as it includes the sum of all changes on master
) and consolidate changes between this and #582.
This PR fixes the issue #699.
It is a co-work, started by @atifaziz in PR #582 (when C# 8 was still in beta)
then completed by @Orace and @moh-hassan when c#8 is becoming released resulting this PR.
The PR is rebased with the last changes in master.
The PR fix the Nullable Reference Types of c# 8 and make MoreLinq C#8 nullable Ready.
Notes:
No change in the public API, except annotating the null parameters in the next two methods: