Except and intersect variations #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised implementation and docs for ExceptBy method group. Added ExceptKeys method group, which shares implementation with ExceptBy. Added unit tests for ExceptKeys.
Added IntersectBy and IntersectKeys method groups, which share the same implementation. Added unit test for both method groups.
Added IntersectAll, IntersectAllBy, and IntersectAllKeys method groups, which share the same implementation. Added unit tests for IntersectAllBy and IntersectAllKeys.
Switched from `foreach` block to `Where` expressions for cleaner implementation code.
…ations All variations of `Except` and `Intersect` are ultimately a special case of the private method in SetFilter.cs. I ran some speed tests between `SetFilterImpl` the existing implementations of these methods, and it appears to be slightly faster, possibly due to some optimization in `Enumerable.Where`.
Split each method group into its own file, and nested them under SetFilter.cs which contains the common implementation and is nested under MoreEnumerable.cs.
Since NUnit v3 ExpectedException is not supported anymore so i replaced all tests with the ThrowsArgumentNullException method.
|
Is there any progress on having this merged? |
|
@atifaziz Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clone of #169 but with corrected changes to pass build.