Except and intersect variations (v3) #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised implementation and docs for ExceptBy method group. Added ExceptKeys method group, which shares implementation with ExceptBy. Added unit tests for ExceptKeys.
Added IntersectBy and IntersectKeys method groups, which share the same implementation. Added unit test for both method groups.
Added IntersectAll, IntersectAllBy, and IntersectAllKeys method groups, which share the same implementation. Added unit tests for IntersectAllBy and IntersectAllKeys.
Switched from `foreach` block to `Where` expressions for cleaner implementation code.
…ations All variations of `Except` and `Intersect` are ultimately a special case of the private method in SetFilter.cs. I ran some speed tests between `SetFilterImpl` the existing implementations of these methods, and it appears to be slightly faster, possibly due to some optimization in `Enumerable.Where`.
Split each method group into its own file, and nested them under SetFilter.cs which contains the common implementation and is nested under MoreEnumerable.cs.
|
Has there been any movement on getting this PR published? I keep coming back to wishing I had access to these variants. |
eliekstein
approved these changes
Nov 17, 2016
|
@eliekstein Do you have time to review the merge conflicts? |
|
@JamesFaix I Could, do you want me to add as a collaborator to your fork? or should i do my own fork? |
Except and intersect variations
This was referenced Feb 28, 2017
|
I've opened another PR #257 which fixes the conflicts and passes all the tests, once that's merged this one could be closed. |
atifaziz
added a commit
to atifaziz/MoreLINQ
that referenced
this pull request
Mar 23, 2018
This puts the copyright notice extenral to main project file and friendlier to eyes and version control management (fewer chances of merge conflicts). It also takes care of an annoying problem where Visual Studio would re-encoding the `&morelinq#169;` to the copyright symbol whenever the project file would be opened in the IDE and which would show up as artificial changes ready for commit to the version control repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch provides several variations of the Except and Intersect operators.
It provides a solution to issues #63 and #124, and can be built upon to resolve #125.