Merge pull request #47 from moosetechnology/refactor-remove-gitmetric…

…4user refactor: remove GitMetric class and subclasses
moosetechnology · Sep 3, 2024 · 75bc8e5 · 75bc8e5
2 parents 0495154 + bae5d11
commit 75bc8e5
Show file tree

Hide file tree

Showing 14 changed files with 201 additions and 476 deletions.
diff --git a/src/GitLabHealth-Model-Analysis/CodeChurnMetric.class.st b/src/GitLabHealth-Model-Analysis/CodeChurnMetric.class.st
@@ -12,12 +12,12 @@ CodeChurnMetric >> calculate [
 
 	| commits res groupedByDate totalContributions gitAnalyzer |
 	userCommits ifNil: [ self load ].
-	
+
 	totalContributions := OrderedCollection new.
 	groupedByDate := self setupGroupedDate.
 	gitAnalyzer := GitAnalyzer new maxChildCommit: maxCommitWindow.
 
-	commits := user
+	commits := self
 		           foundSuccessorOf: userCommits
 		           andCompleteImportForMax: maxCommitWindow.
 

diff --git a/src/GitLabHealth-Model-Analysis/CommentContributionMetric.class.st b/src/GitLabHealth-Model-Analysis/CommentContributionMetric.class.st
@@ -47,7 +47,10 @@ CommentContributionMetric >> description [
 
 { #category : #loading }
 CommentContributionMetric >> load [
-	userCommits := user loadCompleteCommitsSince: (period at: #since) until: (period at: #until). 
+
+	userCommits := self
+		               loadCompleteCommitsSince: (period at: #since)
+		               until: (period at: #until)
 ]
 
 { #category : #accessing }

diff --git a/src/GitLabHealth-Model-Analysis/DelayUntilFirstChurnMetric.class.st b/src/GitLabHealth-Model-Analysis/DelayUntilFirstChurnMetric.class.st
@@ -13,14 +13,14 @@ DelayUntilFirstChurnMetric >> calculate [
 	| commits groupedByDate res average |
 	userCommits ifNil: [ self load ].
 	groupedByDate := self setupGroupedDate.
-	commits := user
+	commits := self
 		           foundSuccessorOf: userCommits
 		           andCompleteImportForMax: maxCommitWindow.
 
 
 	"class commit by dates, filter none user commits"
 	commits do: [ :commit |
-		commit commitCreator = user user ifTrue: [
+		commit commitCreator = user ifTrue: [
 			| overDate |
 			overDate := self transformDate: commit created_at to: over.
 
@@ -59,7 +59,7 @@ DelayUntilFirstChurnMetric >> calculate [
 			       ifFalse: [
 			       (filtered sum: [ :v | v asDuration asSeconds ])
 			       / filtered size ] ].
-	
+
 	res := res reject: #isNil.
 
 	average := res

diff --git a/src/GitLabHealth-Model-Analysis/GitMetric.class.st b/src/GitLabHealth-Model-Analysis/GitMetric.class.st
diff --git a/src/GitLabHealth-Model-Analysis/GitMetric4Group.class.st b/src/GitLabHealth-Model-Analysis/GitMetric4Group.class.st
diff --git a/src/GitLabHealth-Model-Analysis/GitMetric4Project.class.st b/src/GitLabHealth-Model-Analysis/GitMetric4Project.class.st