Merge pull request #79 from moosetechnology/feature/error-with-bigdif…

…f-from-server

Deal with errors when loading big diff

src/GitLabHealth-Model-Importer-Tests/GLHApiMock.class.st

@@ -0,0 +1,12 @@
+Class {
+	#name : #GLHApiMock,
+	#superclass : #GLHApi,
+	#category : #'GitLabHealth-Model-Importer-Tests'
+}
+
+{ #category : #'api - commits' }
+GLHApiMock >> commitDiff: aCommitID ofProject: aProjectId unidiff: aBoolean [
+
+	aCommitID = 'createError' ifTrue: [
+		^ '{"message":"500 Internal Server Error"}' ]
+]

src/GitLabHealth-Model-Importer-Tests/GLHModelImporterLocalTest.class.st

@@ -8,7 +8,7 @@ Class {
 		'importer',
 		'model'
 	],
-	#category : 'GitLabHealth-Model-Importer-Tests'
+	#category : #'GitLabHealth-Model-Importer-Tests'
 }
 
 { #category : #running }
@@ -18,7 +18,22 @@ GLHModelImporterLocalTest >> setUp [
 
 	importer := GLHModelImporter new.
 	model := GLPHEModel new.
-	importer glhModel: model
+	importer glhModel: model.
+	importer glhApi: GLHApiMock new
+]
+
+{ #category : #tests }
+GLHModelImporterLocalTest >> testImportDiffOfCommitWithServerRaiseError [
+
+	| commit repo project |
+	commit := model newCommit.
+	commit id: 'createError'.
+	repo := model newRepository.
+	commit repository: repo.
+	project := model newProject.
+	repo project: project.
+	importer importDiffOfCommit: commit.
+	self assert: commit diffs isEmpty
 ]
 
 { #category : #tests }
@@ -31,3 +46,10 @@ GLHModelImporterLocalTest >> testImportUserAlreadyInModel [
 	model add: user.
 	self assert: (importer importUser: 12) equals: user
 ]
+
+{ #category : #tests }
+GLHModelImporterLocalTest >> testIsServerError [
+
+	self assert:
+		(importer isServerError: '{"message":"500 Internal Server Error"}')
+]

src/GitLabHealth-Model-Importer/GLHModelImporter.class.st

@@ -611,6 +611,7 @@ GLHModelImporter >> importDiffOfCommit: aCommit [
 		          commitDiff: aCommit id
 		          ofProject: aCommit repository project id
 		          unidiff: true.
+	(self isServerError: result) ifTrue: [ ^ {  } ].
 	diffsResult := self newParseDiffResult: result.
 
 	^ aCommit diffs addAll: diffsResult unless: self blockForDiffEquality.
@@ -926,6 +927,11 @@ GLHModelImporter >> initialize [
 
 ]
 
+{ #category : #api }
+GLHModelImporter >> isServerError: aString [
+	^ aString = '{"message":"500 Internal Server Error"}'
+]
+
 { #category : #importer }
 GLHModelImporter >> loadAllProjectsFromRepositorySoftware [
 	"heavy import that load all the active project inside the model. Only import the project entities"