Login in dockerhub when possible to avoid pull limits #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With current pull limits @ dockerhub, it's possible to get failed jobs just running 2-3 builds (each one having a good number of jobs). With this patch, if both DOCKER_USER and DOCKER_TOKEN are defined as environmental variables, they will be used to perform a login to dockerhub, getting rid of pull limits.
|
Please, do not merge this yet, it's WIP stuff (I just needed to make the PR to verify the dockerhub credentials are working as expected). |
stronk7
force-pushed
the
authenticated_docker
branch
2 times, most recently
from
2f3bcfc to
c64cf3a
Compare
|
It's passing ok:
|
This was referenced Jan 26, 2021
Consider adding opt-in support to dockerhub based on env vars / secrets
moodlehq/moodle-plugin-ci#70
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current pull limits @ dockerhub, it's possible to get failed
jobs just running 2-3 builds (each one having a good number of jobs).
With this patch, if both DOCKER_USER and DOCKER_TOKEN are defined
as environmental variables, they will be used to perform a login
to dockerhub, getting rid of pull limits.