Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding opt-in support to dockerhub based on env vars / secrets #70

Open
stronk7 opened this issue Jan 26, 2021 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@stronk7
Copy link
Member

stronk7 commented Jan 26, 2021

Pretty much like it was done @ moodle-docker for travis (we were hitting the limits there).

moodlehq/moodle-docker#150

We should do the same here for:

  • own moodle-plugin-ci CI (travis and gha).
  • recommended (for plugins) templates (travis and gha). Plus document.

Ciao :-)

PS: Note I've remembered about this because I've hit the limits with travis with moodle-plugin-ci, and it was just after 10-12 pushes, so it can happen with relative frequency.

@stronk7 stronk7 added the enhancement New feature or request label Jan 26, 2021
@stronk7
Copy link
Member Author

stronk7 commented Jan 29, 2021

I was curious about some intense / repetitive / big matrix runs I've performed lately with GHA, because they were not hitting DockerHub limits. And, the very same runs, via TravisCI, are hitting them.

So, after a bit of searching, I found this:

actions/runner-images#1445 (comment)

Basically it seems that Github reached and agreement with Docker and no limits apply to public containers being used by GitHub runners. If private containers or self-hosted runners are used, then credentials may be needed.

So that explains why "normal" jobs aren't hit, so this issue is less critical than I initially was thinking.

Still we have to decide if we want to give any support for those 2 groups (private containers and self-hosted runners).

Ciao :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant