Regression: Migrating the before_standard_html_head() function to the new hook callback broke the login page on Moodle 4.3, resolves #613 #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new hook callback broke the login page on Moodle 4.3, resolves #613
|
The tests have passed (the codechecker just fails because of moodlehq/moodle-cs#142 which is out of our scope) |
detomon
pushed a commit
to detomon/moodle-theme_boost_union
that referenced
this pull request
Aug 26, 2024
… new hook callback broke the login page on Moodle 4.3, resolves moodle-an-hochschulen#613 (moodle-an-hochschulen#614)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not add anything to CHANGES.md as there has not been any release between the integration of #605 and this PR.