Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Migrating the before_standard_html_head() function to the new hook callback broke the login page on Moodle 4.3 #613

Closed
abias opened this issue Mar 30, 2024 · 0 comments
Closed

Regression: Migrating the before_standard_html_head() function to the new hook callback broke the login page on Moodle 4.3 #613

abias opened this issue Mar 30, 2024 · 0 comments
Assignees
@abias
Labels
bug Something which isn't working

Comments

@abias
Copy link
Member

abias commented Mar 30, 2024

The PR #605 contained a regression, unfortunately, which may lead to this error message on the login page:
grafik

This is because I forgot to require locallib.php and the login page does not include locallib.php anywhere else.
@abias abias added the bug Something which isn't working label Mar 30, 2024
@abias abias self-assigned this Mar 30, 2024
abias added a commit that referenced this issue Mar 30, 2024
@abias
Regression: Migrating the before_standard_html_head() function to the…
89c22ac 
… new hook callback broke the login page on Moodle 4.3, resolves #613
@abias abias moved this to Ready for REVIEW in Boost Union Planning Board Mar 30, 2024
@abias abias closed this as completed in f4f0bcc Mar 31, 2024
@github-project-automation github-project-automation bot moved this from Ready for REVIEW to Ready for Backport in Boost Union Planning Board Mar 31, 2024
abias added a commit that referenced this issue Apr 6, 2024
@abias
Regression: Migrating the before_standard_html_head() function to the…
d606517 
… new hook callback broke the login page on Moodle 4.3, resolves #613 (#614)
abias added a commit that referenced this issue Apr 6, 2024
@abias
Regression: Migrating the before_standard_html_head() function to the…
36aa0b3 
… new hook callback broke the login page on Moodle 4.3, resolves #613 (#614)
abias added a commit that referenced this issue Apr 6, 2024
@abias
Regression: Migrating the before_standard_html_head() function to the…
6a6d916 
… new hook callback broke the login page on Moodle 4.3, resolves #613 (#614)
@abias abias moved this from Ready for Backport to Ready for Release in Boost Union Planning Board Apr 6, 2024
@abias abias moved this from Ready for Release to CLOSED in Boost Union Planning Board Apr 7, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@abias
Regression: Migrating the before_standard_html_head() function to the…
631135f 
… new hook callback broke the login page on Moodle 4.3, resolves moodle-an-hochschulen#613 (moodle-an-hochschulen#614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abias abias

Labels
bug Something which isn't working
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abias