Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer displacement on pages with minimal content #655

Closed
Sebbsen opened this issue May 13, 2024 · 3 comments · Fixed by #705
Closed

Footer displacement on pages with minimal content #655

Sebbsen opened this issue May 13, 2024 · 3 comments · Fixed by #705
Assignees
Labels
bug Something which isn't working good first issue Something which can be addressed by newcomers in reasonable time

Comments

@Sebbsen
Copy link

Sebbsen commented May 13, 2024

Describe the bug
The footer does not stay at the bottom of the screen when there isn't enough content on the page to fill the viewport. This bug has previously occurred #269 and was fixed #309, but it has reappeared, likely due to a recent update.

To Reproduce

  1. Go to or create a page with minimal content.
  2. Observe that the footer does not stick to the bottom of the viewport but moves up, leaving a gap beneath it.

Expected behavior
The footer should remain at the bottom of the screen, regardless of the amount of content on the page.

Screenshots
The footer contains only "Lorem Ipsum" as placeholder text.
Screen size is is 1920x1080

footer-bug

Desktop:

  • OS: MacOs 14.0 (23A344)
  • Browser: Chrome
  • Version: 124.0.6367.119
@Sebbsen Sebbsen added the new Something which has been reported but has not yet beeen triaged by the team label May 13, 2024
@whuml whuml added the bug Something which isn't working label May 23, 2024
@whuml
Copy link
Collaborator

whuml commented May 23, 2024

Hallo @Sebbsen

thanks for posting this issue.
I recogized same bahaviour at core Moodle at their https://sandbox.moodledemo.net/ .
As we already fixed it at boost union #269 and #309 I added our "bug" label for fixing that with boost union again.

brgds
Wolfgang

@whuml whuml removed the new Something which has been reported but has not yet beeen triaged by the team label May 23, 2024
@whuml whuml moved this to Ready for DEV in Boost Union Planning Board May 23, 2024
@whuml whuml added the good first issue Something which can be addressed by newcomers in reasonable time label May 23, 2024
@LisaE14
Copy link

LisaE14 commented Aug 22, 2024

We have the same problem. When can we expect it to be fixed?

@Menrath
Copy link
Contributor

Menrath commented Aug 26, 2024

As we already fixed it at boost union #269 and #309 I added our "bug" label for fixing that with boost union again.

#309 added the flex: 1 0 auto; to the main-inner-wrapper CSS-class. Seems like this is not enough anymore, the element with the id page (and maybe also page-wrapper) need this as well:

 #page-wrapper #page {
    flex: 1 0 auto;
}

Menrath added a commit to Menrath/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@abias abias moved this from Ready for DEV to Ready for REVIEW in Boost Union Planning Board Nov 13, 2024
@abias abias moved this from Ready for REVIEW to In Progress REVIEW in Boost Union Planning Board Nov 18, 2024
abias pushed a commit to Menrath/moodle-theme_boost_union that referenced this issue Nov 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress REVIEW to Ready for BACKPORT in Boost Union Planning Board Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something which isn't working good first issue Something which can be addressed by newcomers in reasonable time
Projects
Status: CLOSED
4 participants