Fix footer displacement on pages with minimal content (#705)

solves #655
moodle-an-hochschulen · Nov 18, 2024 · a3fbf0c · a3fbf0c
1 parent 9a881c8
commit a3fbf0c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased
 
+* 2024-11-18 - Bugfix: Footer displacement on pages with minimal content, resolves #655.
 * 2024-11-18 - Upstream change: Adopt changes from MDL-77732 ('Custom menu items do not receive active behaviour'), resolves #436 #620 #384 #715.
 * 2024-11-13 - Upstream change: Adopt changes from MDL-78999 ('Site logo does not appear in mobile view'), resolves #753.
 * 2024-11-11 - Release: Add ssystems GmbH to the list of maintainers in README.md.

diff --git a/scss/boost_union/post.scss b/scss/boost_union/post.scss
@@ -645,11 +645,14 @@ body.theme-boost-union-commincourse {
 
 /* To support additional block regions around the main content area, Boost Union introduced
    the main-inner-wrapper HTML element. Unfortunately, this breaks the Flexbox flow of Moodle core.
-   To make it work again, we have to set the Flexbox flex attribute in the main-inner-wrapper element as well. */
-.main-inner-wrapper {
+   To make it work again, we have to set the Flexbox flex attribute in the main-inner-wrapper element as well.
+   In addition to that, we set the Flexbox attribute for the #page element as well as it turned out to be necessary. */
+.main-inner-wrapper,
+#page-wrapper #page {
     flex: 1 0 auto;
 }
 
+
 /*---------------------------------------
  * Settings: Additional block regions - The offcanvas region.
  --------------------------------------*/