Skip to content

Commit

Permalink
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
Browse files Browse the repository at this point in the history
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
  • Loading branch information
abias committed Oct 22, 2024
1 parent 405b02e commit bd9f73e
Show file tree
Hide file tree
Showing 3 changed files with 102 additions and 56 deletions.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ Changes

### Unreleased

* 2024-10-13 - Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
* 2024-10-13 - Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php was split up.
* 2024-10-13 - Upgrade: Adopt changes from MDL-75671 in navbar.mustache
* 2024-10-13 - Upgrade: Adopt changes from MDL-81725 in cm.mustache
* 2024-10-13 - Upgrade: Adopt changes from MDL-75671 in cm.mustache
Expand Down
3 changes: 2 additions & 1 deletion UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ Upstream changes
----------------

* This theme is built on top of theme_boost from Moodle core. It inherits the codebase from theme_boost and overwrites and extends several behaviours and functions. Doing this, code duplication couldn't be avoided. If there are any upstream changes in theme_boost, you should check if they should be adopted to this theme as well.
* In addition to that, you should check any upstream changes which happen in /lib/templates and /lib/outputrenderers.php as some of these templates and renderers are overwritten in this theme as well.
* In addition to that, you should check any upstream changes which happen in /lib/templates, /lib/classes/output/core_renderer.php and /lib/classes/output/renderer_base.php as some of these templates and renderers are overwritten in this theme as well.
* In addition to that, you should check any occurences of 'copied and modified' in Boost Union as these comments might indicate additional places where you have to check upstream changes.
* In addition to that, you should check if any additions to theme_boost_union_get_scss_to_mark_external_links() should be made. This might be particularly necessary if any new links have been added to the footer questionmark icon in Moodle core (have a look at footer.mustache) or if any links have been added which have a hardcoded external-link icon (check for new occurrences of "i/externallink" in the Moodle codebase).


Expand Down
Loading

0 comments on commit bd9f73e

Please sign in to comment.