Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: Remove legacy implementation of before_standard_html_head() #606

Closed
abias opened this issue Mar 23, 2024 · 1 comment
Closed

Upgrade: Remove legacy implementation of before_standard_html_head() #606

abias opened this issue Mar 23, 2024 · 1 comment
Assignees
@abias
Labels
affecting 4.5 only Something which only affects Moodle 4.5 upgrade Something which needs to be done to upgrade the plugin to a new Moodle major release

Comments

@abias
Copy link
Member

abias commented Mar 23, 2024 •
edited
Loading

#605 adds a backwards-compatible implementation of before_standard_html_head() together with the new hooks implementation to the codebase.

However, as soon as 4.1 LTS is out of support (december 2025), the implementation can be improved to only use the hooks implementation in the end.
@abias abias added upgrade Something which needs to be done to upgrade the plugin to a new Moodle major release affecting 4.4 only Something which only affects Moodle 4.4 affecting 4.5 only Something which only affects Moodle 4.5 affecting 4.6 only Something which only affects Moodle 4.6 affecting 4.7 only Something which only affects Moodle 4.7 labels Mar 23, 2024
@abias abias moved this to On hold in Boost Union Planning Board Mar 23, 2024
@abias abias changed the title Upgrade: Remove legacy implementation of before_standard_html_head() Upgrade: Remove legacy implementation of before_standard_html_head() and after_config() Oct 10, 2024
@abias abias changed the title Upgrade: Remove legacy implementation of before_standard_html_head() and after_config() Upgrade: Remove legacy implementation of before_standard_html_head() Oct 10, 2024
@abias abias self-assigned this Oct 13, 2024
@abias abias removed affecting 4.4 only Something which only affects Moodle 4.4 affecting 4.6 only Something which only affects Moodle 4.6 affecting 4.7 only Something which only affects Moodle 4.7 labels Oct 13, 2024
@abias
Copy link
Member Author

abias commented Oct 13, 2024

The legacy implementation will be removed in the 4.5 release of Boost Union.

@abias abias closed this as completed Oct 13, 2024
@github-project-automation github-project-automation bot moved this from On hold to Ready for Backport in Boost Union Planning Board Oct 13, 2024
@abias abias moved this from Ready for Backport to Ready for Release in Boost Union Planning Board Oct 13, 2024
abias added a commit that referenced this issue Oct 13, 2024
@abias
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
0e3d020 
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
abias added a commit that referenced this issue Oct 15, 2024
@abias
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
e0d0282 
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
abias added a commit that referenced this issue Oct 15, 2024
@abias
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
fe00c00 
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
abias added a commit that referenced this issue Oct 15, 2024
@abias
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
058a10a 
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
abias added a commit that referenced this issue Oct 15, 2024
@abias
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
bd9faa0 
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
abias added a commit that referenced this issue Oct 18, 2024
@abias
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
5f39c2a 
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
abias added a commit that referenced this issue Oct 21, 2024
@abias
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
3108c6d 
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
abias added a commit that referenced this issue Oct 21, 2024
@abias
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
fd3c908 
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
abias added a commit that referenced this issue Oct 22, 2024
@abias
Upgrade: Adopt changes from MDL-82183 where lib/outputrenderers.php w…
bd9f73e 
…as split up + Upgrade: Remove legacy implementation of before_standard_html_head, resolves #606.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abias abias

Labels
affecting 4.5 only Something which only affects Moodle 4.5 upgrade Something which needs to be done to upgrade the plugin to a new Moodle major release
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abias