Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split licences into multiple sections to avoid rendering issues #144

Merged
merged 7 commits into from
Oct 19, 2020
Merged

Split licences into multiple sections to avoid rendering issues #144

merged 7 commits into from
Oct 19, 2020

Conversation

Cyberbeni
Copy link
Contributor

This will only impact licences that contain horizontal line separators (at least 3 -_*= between two double linebreaks)

iOS14 has huge gaps between the groups, so splitting on every double linebreak would be overkill.

Resolves #138

@mono0926
Copy link
Owner

@Cyberbeni

Thanks for the PR 🙏
Could you add a test case to https://github.com/mono0926/LicensePlist/blob/master/Tests/LicensePlistTests/Entity/LicensePlistHolderTests.swift ?

@mono0926 mono0926 merged commit 85a84de into mono0926:master Oct 19, 2020
@mono0926
Copy link
Owner

@Cyberbeni Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mapbox license not visible
2 participants
@Cyberbeni @mono0926