Mapbox license not visible

[illabo]

Hello there!

On older iOS versions (tried on iOS 10.3 and 12.1) Mapbox-iOS-SDK license not visible in settings. However scroll view scrolls vertically a lot as if the text is visible actually. When copy paste it to txt file and load it manually from file set in license_plist.yml it is invisible too. In iOS 13 it is displayed ok if not crashing settings app.

Perhaps there are some illegal characters in the text? Maybe texts should be preparsed escaping such a characters?

[illabo]

I've tried running my app on even older device. On iPhone 4s with iOS 9.3.6 all the licenses are offset one screen height from top. However Mapbox-iOS-SDK license is visible! Thinking I was wrong not to scroll it on iOS 10—12 all way down, maybe it's just offset too. But no.

All the licenses are visible ok, except Mapbox's. And it isn't offset as on iOS 9.

[Cyberbeni]

Maybe it is too long. What happens if you split it into smaller chunks, can all of them render?

[illabo]

Thanks for suggestion. Maybe its length is the reason however other quite long texts are visible ok.
Haven’t tried splitting as it is against of idea of licenses convenient presentation.

[Cyberbeni]

I mean we are jamming all the text into one footer, which probably uses a UILabel, which doesn't care about not showing all its content inside the tableview's scrollview, so it tries to render all the text at once. We could try splitting up the paragraphs and use separate elements for them if that is the cause of the problem.

[Cyberbeni]

@illabo could you try my version from here? https://github.com/Cyberbeni/LicensePlist/tree/multiple-footers

Installing from source: https://github.com/mono0926/LicensePlist#from-source

It splits double newlines to different footers, which results in a slightly bigger gap between them but if it solves the issue then I think that's acceptable.

I initially also converted single newlines to spaces but then I realised maybe not all licences in markdown, so I'll leave that for another issue.

[Cyberbeni]

It works on iOS 10.3 simulator
The gaps are way bigger on iOS14, might be better to split on horizontal lines.

[illabo]

@Cyberbeni Sorry, I haven’t checked your fork yet. The issue is only present in older iOS versions. Starting with iOS 13 everything looks great. Maybe it’s better to check iOS version before splitting the long text?
Sorry again, I definitely have to take a look at your version.