Assembly load/unload tests and fixes #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutch
force-pushed
the
test-ref-asm
branch
from
11ad88a
to
9f28051
Compare
So it's easier to debug
mhutch
force-pushed
the
test-ref-asm
branch
2 times, most recently
from
640e7eb
to
85fac66
Compare
This works around an issue in Mono where the MarshalByRefObject proxy for the CompiledTemplate in the templating AppDomain seems becomes an uninitalized type in the local domain after being passed across a couple async calls.
This causes the tests to run in an AppDomain where the BaseDirectory in the directory containing the tests assembly, else it's the directory containing the xUnit test runner. This allows the AppDomain created for executing templates to find the Mono.TextTemplating.dll assembly, which it requires for remoting. Hopefully the intermittent Mono hang that caused us to disable the xUnit AppDomain is fixed.... Fixed the templating AppDomain has the same base directory, and can then to find Mono.TextTemplating.dll,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.