Disable noncritical tests on Mono that fail due to Mono AppDomain bugs

mono · Oct 3, 2022 · 4619a50 · 4619a50
1 parent 4659e4f
commit 4619a50
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/Mono.TextTemplating.Tests/AppDomainTests.cs b/Mono.TextTemplating.Tests/AppDomainTests.cs
@@ -19,6 +19,11 @@ public class AppDomainTests : AssemblyLoadTests<SnapshotSet<string>>
 
 	protected override void CleanupGenerator (TemplateGenerator generator)
 	{
+		// FIXME: app domain unload doesn't seem to work on Mono
+		if (FactExceptOnMonoAttribute.IsRunningOnMono) {
+			return;
+		}
+
 		// verify that the AppDomain is collected
 		var weakRef = ((TestTemplateGeneratorWithAppDomain)generator).ReleaseDomain ();
 		int count = 0;
@@ -107,6 +112,7 @@ class TestTemplateGeneratorWithAppDomain : TemplateGenerator
 
 		public WeakReference ReleaseDomain ()
 		{
+			AppDomain.Unload (appDomain);
 			var weakRef = new WeakReference (appDomain);
 			appDomain = null;
 			return weakRef;

diff --git a/Mono.TextTemplating.Tests/AssemblyLoadTests.cs b/Mono.TextTemplating.Tests/AssemblyLoadTests.cs
@@ -62,7 +62,7 @@ public async Task LoadOpenApiReadersDll ()
 		VerifyFinalState (state);
 	}
 
-	[Fact]
+	[FactExceptOnMono ("Mono incorrectly resolves the assembly if it has been loaded in a different AppDomain")]
 	public async Task MissingTransitiveReference ()
 	{
 		var gen = CreateGenerator ();
@@ -80,4 +80,16 @@ public async Task MissingTransitiveReference ()
 
 		CleanupGenerator (gen);
 	}
+}
+
+public class FactExceptOnMonoAttribute : FactAttribute
+{
+	public FactExceptOnMonoAttribute (string reason)
+	{
+		if (IsRunningOnMono) {
+			Skip = reason;
+		}
+	}
+
+	public static bool IsRunningOnMono { get; } = System.Type.GetType ("Mono.Runtime") != null;
 }