Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve hyphen error in issue #5948 (@sarthaknimbalkar) #5953

Closed

Conversation

sarthaknimbalkar
Copy link

@sarthaknimbalkar sarthaknimbalkar commented Oct 7, 2024

Description

This pull request introduces two significant changes:

  1. Renaming Layouts: The following layouts have been renamed to valid names:

    • Original: 3l*(*white space here) , seht-drai, saiga-e
    • New: 3l, seht_drai, saiga_e
      These changes were made in the file located at monkeytype/frontend/static/layouts/_list.json.
  2. Validation Implementation: A validation mechanism has been implemented in the file monkeytype/frontend/src/ts/config-validation.ts to ensure that layout names conform to the new naming conventions.
    This enhancement allows us to display layout names without hyphens or underscores. For example, "seht_drai" will now appear as "seht drai," along with all such other similar names.

Checks

  • Adding a Language or a Theme?
    • [ x ] If this is a language, confirm that you edited _list.json, _groups.json, and added languages.json.

Closes #5948

There was another PR attempt made by @m4dd0c #5951

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Oct 7, 2024
@sarthaknimbalkar sarthaknimbalkar changed the title fix: resolve hyphen error in issue #5948 @sarthaknimbalkar fix: resolve hyphen error in issue #5948 (@sarthaknimbalkar) Oct 7, 2024
@fehmer
Copy link
Member

fehmer commented Oct 7, 2024

@Miodec
Copy link
Member

Miodec commented Oct 7, 2024

Thank you, however we are going to go with #5951 as it was opened first. (plus it includes some unnecessary changes as fehmer mentioned)

@Miodec Miodec closed this Oct 7, 2024
@sarthaknimbalkar
Copy link
Author

Sure,
Thank you for the feedback ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to emulate some layouts
4 participants