Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): layout emulator values modified according to schema (@m4dd0c) #5951

Closed

Conversation

m4dd0c
Copy link
Contributor

@m4dd0c m4dd0c commented Oct 7, 2024

Description

Some Layout Emulator values were not aligned with the current schema.
So they were changed accordingly.

Checks

  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • Changed layouts/_list.json

Closes #5948

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Oct 7, 2024
@fehmer
Copy link
Member

fehmer commented Oct 7, 2024

I tested the three layouts with the code before #5649 and it was broken as well. So I guess renaming the layouts is the right way to solve this.

@sarthaknimbalkar
Copy link

Hi @fehmer, I've submitted another pull request that includes validation implementation along with some renaming. Could you please take a look and let me know if any changes are needed?

@Miodec
Copy link
Member

Miodec commented Oct 7, 2024

I would like to respect the original names chosen by the layout creators. Instead of changing the layout names just update the layout schema in the contracts package to allow for -. (just duplicate the keymap layout schema into layout schema)

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Oct 7, 2024
@m4dd0c m4dd0c closed this by deleting the head repository Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to emulate some layouts
5 participants