Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fixes converting to TPF by including all attributes in replication_specs #2894

Merged
merged 1 commit into from
Dec 16, 2024
Merged

chore: Fixes converting to TPF by including all attributes in replication_specs #2894

merged 1 commit into from
Dec 16, 2024

Conversation

EspenAlbert
Copy link
Collaborator

Description

Fixes converting to TPF by including all attributes in replication_specs

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

lantoli
lantoli reviewed Dec 14, 2024
View reviewed changes
internal/testutil/acc/advanced_cluster_schema_v2_test.go
@@ -56,6 +56,7 @@ func TestConvertAdvancedClusterToSchemaV2(t *testing.T) {
cluster_type = "SHARDED"

replication_specs {
zone_name = "zone1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

lantoli
lantoli approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EspenAlbert EspenAlbert marked this pull request as ready for review December 16, 2024 07:52
@EspenAlbert EspenAlbert requested a review from a team as a code owner December 16, 2024 07:52
@EspenAlbert EspenAlbert merged commit 47633ce into master Dec 16, 2024
46 checks passed
@EspenAlbert EspenAlbert deleted the tf_config_tpf_rep_spec_fix branch December 16, 2024 13:37
lantoli added a commit that referenced this pull request Dec 16, 2024
@lantoli
Merge branch 'master' into CLOUDP-290307_data_source_legacy_view
75b5c25 
* master:
  chore: Refactors fail_index_key_too_long to be compatible with old implementation and use zero values in advanced_configuration (#2893)
  chore: Fixes converting to TPF by including all attributes in replication_specs (#2894)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maastha maastha maastha approved these changes

@oarbusi oarbusi oarbusi approved these changes

@lantoli lantoli lantoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EspenAlbert @lantoli @oarbusi @maastha