-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactors fail_index_key_too_long to be compatible with old implementation and use zero values in advanced_configuration #2893
chore: Refactors fail_index_key_too_long to be compatible with old implementation and use zero values in advanced_configuration #2893
Conversation
…lementation and use zero values in advanced_configuration
internal/service/advancedclustertpf/model_ClusterDescriptionProcessArgs20240805.go
Outdated
Show resolved
Hide resolved
if stateConfigSDK != nil && stateConfigSDK.GetFailIndexKeyTooLong() != failIndexKeyTooLong { | ||
failIndexKeyTooLong = stateConfigSDK.GetFailIndexKeyTooLong() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: If FailIndexKeyTooLong is not defined in API response because an old mongodb version is used, wouldnt we want the user to be aware that this property was not set? How does this scenario work in SDK v2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In SDK v2 we use the Getter
methods:
"fail_index_key_too_long": p20240530.GetFailIndexKeyTooLong(),
So even when the API returns null
it will still be set to false
Description
Refactors fail_index_key_too_long to be compatible with old implementation and use zero values in advanced_configuration
Link to any related issue(s): CLOUDP-287995
Type of change:
Required Checklist:
Further comments