Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactors fail_index_key_too_long to be compatible with old implementation and use zero values in advanced_configuration #2893

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

EspenAlbert
Copy link
Collaborator

Description

Refactors fail_index_key_too_long to be compatible with old implementation and use zero values in advanced_configuration

Link to any related issue(s): CLOUDP-287995

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert marked this pull request as ready for review December 16, 2024 08:10
@EspenAlbert EspenAlbert requested a review from a team as a code owner December 16, 2024 08:10
Comment on lines +30 to +32
if stateConfigSDK != nil && stateConfigSDK.GetFailIndexKeyTooLong() != failIndexKeyTooLong {
failIndexKeyTooLong = stateConfigSDK.GetFailIndexKeyTooLong()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: If FailIndexKeyTooLong is not defined in API response because an old mongodb version is used, wouldnt we want the user to be aware that this property was not set? How does this scenario work in SDK v2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In SDK v2 we use the Getter methods:
"fail_index_key_too_long": p20240530.GetFailIndexKeyTooLong(),
So even when the API returns null it will still be set to false

@EspenAlbert EspenAlbert merged commit 064955c into master Dec 16, 2024
45 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-287995_fail_index_key_too_long_workaround branch December 16, 2024 13:38
lantoli added a commit that referenced this pull request Dec 16, 2024
* master:
  chore: Refactors fail_index_key_too_long to be compatible with old implementation and use zero values in advanced_configuration (#2893)
  chore: Fixes converting to TPF by including all attributes in replication_specs (#2894)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants