Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-3021 Skip tests with errorCodeName on Serverless #1680

Merged
merged 5 commits into from
Oct 31, 2024
Merged

DRIVERS-3021 Skip tests with errorCodeName on Serverless #1680

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
939f117
skip tests expecting an `errorCodeName` on serverless
kevinAlbs Oct 22, 2024
a0d62b9
regenerate JSON files
kevinAlbs Oct 22, 2024
9272902
use schema version 1.4 for `serverless` in `runOnRequirements`
kevinAlbs Oct 29, 2024
5149d98
regenerate JSON files
kevinAlbs Oct 29, 2024
b93a454
revert unnecessary skips
kevinAlbs Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions source/transactions-convenient-api/tests/unified/commit-retry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,11 @@
},
{
"description": "commit is not retried after MaxTimeMSExpired error",
baileympearson marked this conversation as resolved.
Show resolved Hide resolved
"runOnRequirements": [
{
"serverless": "forbid"
}
],
"operations": [
{
"name": "failPoint",
Expand Down
3 changes: 3 additions & 0 deletions source/transactions-convenient-api/tests/unified/commit-retry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,9 @@ tests:
- { _id: 1 }
-
description: commit is not retried after MaxTimeMSExpired error
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand Down
17 changes: 16 additions & 1 deletion source/transactions-convenient-api/tests/unified/commit-writeconcernerror.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"description": "commit-writeconcernerror",
"schemaVersion": "1.3",
"schemaVersion": "1.4",
"runOnRequirements": [
{
"minServerVersion": "4.0",
Expand Down Expand Up @@ -414,6 +414,11 @@
},
{
"description": "commitTransaction is not retried after UnknownReplWriteConcern error",
"runOnRequirements": [
{
"serverless": "forbid"
}
],
"operations": [
{
"name": "failPoint",
Expand Down Expand Up @@ -546,6 +551,11 @@
},
{
"description": "commitTransaction is not retried after UnsatisfiableWriteConcern error",
"runOnRequirements": [
{
"serverless": "forbid"
}
],
"operations": [
{
"name": "failPoint",
Expand Down Expand Up @@ -678,6 +688,11 @@
},
{
"description": "commitTransaction is not retried after MaxTimeMSExpired error",
"runOnRequirements": [
{
"serverless": "forbid"
}
],
"operations": [
{
"name": "failPoint",
Expand Down
11 changes: 10 additions & 1 deletion source/transactions-convenient-api/tests/unified/commit-writeconcernerror.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
description: commit-writeconcernerror

schemaVersion: '1.3'
schemaVersion: '1.4' # For `serverless` in `runOnRequirements`

runOnRequirements:
- minServerVersion: '4.0'
Expand Down Expand Up @@ -151,6 +151,9 @@ tests:
outcome: *outcome
-
description: commitTransaction is not retried after UnknownReplWriteConcern error
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand Down Expand Up @@ -203,6 +206,9 @@ tests:
outcome: *outcome
-
description: commitTransaction is not retried after UnsatisfiableWriteConcern error
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand All @@ -226,6 +232,9 @@ tests:
outcome: *outcome
-
description: commitTransaction is not retried after MaxTimeMSExpired error
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand Down
7 changes: 6 additions & 1 deletion source/transactions/tests/unified/abort.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion source/transactions/tests/unified/abort.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
description: abort

schemaVersion: '1.3'
schemaVersion: '1.4' # For `serverless` in `runOnRequirements`

runOnRequirements:
-
Expand Down Expand Up @@ -348,6 +348,9 @@ tests:
- { _id: 1 }
-
description: 'abort ignores TransactionAborted'
baileympearson marked this conversation as resolved.
Show resolved Hide resolved
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
-
object: *session0
Expand Down
7 changes: 6 additions & 1 deletion source/transactions/tests/unified/count.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions source/transactions/tests/unified/count.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
description: count

schemaVersion: '1.3'
schemaVersion: '1.4' # For `serverless` in `runOnRequirements`

runOnRequirements:
# SERVER-35388 introduced OperationNotSupportedInTransaction in 4.0.2
Expand Down Expand Up @@ -49,6 +49,9 @@ initialData:
tests:
-
description: count
runOnRequirements:
baileympearson marked this conversation as resolved.
Show resolved Hide resolved
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
-
object: *session0
Expand Down Expand Up @@ -99,4 +102,4 @@ tests:
-
collectionName: *collection_name
databaseName: *database_name
documents: *data
documents: *data
12 changes: 11 additions & 1 deletion source/transactions/tests/unified/errors.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion source/transactions/tests/unified/errors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
description: errors

schemaVersion: '1.3'
schemaVersion: '1.4' # For `serverless` in `runOnRequirements`

runOnRequirements:
-
Expand Down Expand Up @@ -110,6 +110,9 @@ tests:
errorContains: 'transaction already in progress'
-
description: 'write conflict commit'
runOnRequirements:
baileympearson marked this conversation as resolved.
Show resolved Hide resolved
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
-
object: *session0
Expand Down Expand Up @@ -151,6 +154,9 @@ tests:
- UnknownTransactionCommitResult
-
description: 'write conflict abort'
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
-
object: *session0
Expand Down
5 changes: 5 additions & 0 deletions source/transactions/tests/unified/retryable-commit.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions source/transactions/tests/unified/retryable-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ initialData:
tests:
-
description: 'commitTransaction fails after Interrupted'
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
-
object: testRunner
Expand Down
Loading