-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-3021 Skip tests with errorCodeName
on Serverless
#1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serverless may set an empty `codeName` due to CLOUDP-280424
kevinAlbs
changed the title
Skip tests with
DRIVERS-3021 Skip tests with Oct 29, 2024
errorCodeName
on ServerlesserrorCodeName
on Serverless
kevinAlbs
requested review from
durran and
baileympearson
and removed request for
a team and
durran
October 29, 2024 17:41
baileympearson
requested changes
Oct 29, 2024
kevinAlbs
commented
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes verified by this patch build.
kevinAlbs
added a commit
to kevinAlbs/mongo-rust-driver
that referenced
this pull request
Oct 30, 2024
baileympearson
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kevinAlbs
added a commit
to mongodb/mongo-rust-driver
that referenced
this pull request
Oct 31, 2024
* RUST-2042 sync fle2v2-Rangev2-Compact to 9058491f2d5b5651913a56e373121a24d6498673 * sync tests updated in 24817a5caa0526725d480f9a8b3fbb8714507311 * RUST-2076 sync tests updated in mongodb/specifications#1680
5 tasks
kevinAlbs
added a commit
to kevinAlbs/specifications
that referenced
this pull request
Nov 20, 2024
…ongodb#1680)" This reverts commit 5f6fd28.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skip tests with a
errorCodeName
expectation due to a failpoint. This is intended to workaround CLOUDP-280424.Verified with Rust driver in this patch also containing #1679.
Background & Motivation
Test failures appear related to a recent upgrade to the proxy in Atlas Serverless. The upgrade was requested to get the test passing in #1654 (see thread in #ask-cloud-atlas-serverless).
Please complete the following before merging:
[ ] Update changelog.[ ] Make sure there are generated JSON files from the YAML test files.[ ] Test these changes against all server versions and topologies (including standalone, replica set, shardedclusters, and serverless).