Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(NODE-5012): break apart mongosh integration tests (#3546) #3559

Merged
merged 2 commits into from
Feb 10, 2023
Merged

ci(NODE-5012): break apart mongosh integration tests (#3546) #3559

merged 2 commits into from
Feb 10, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Feb 7, 2023 •
edited
Loading

Description

What is changing?

Applies changes from #3546 into main.

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review February 8, 2023 15:24
@baileympearson baileympearson force-pushed the NODE-5031-mongosh-tests-main branch from 2c2bd84 to bdad38a Compare February 9, 2023 19:25
@baileympearson baileympearson requested a review from durran February 9, 2023 19:25
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 10, 2023
durran
durran approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures on latest consistent with all the other latest server failures and unrelated.

@durran durran merged commit 4fdd257 into main Feb 10, 2023
@durran durran deleted the NODE-5031-mongosh-tests-main branch February 10, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @durran