Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(NODE-5012): break apart mongosh integration tests #3546

Merged
merged 14 commits into from
Feb 7, 2023
Merged

ci(NODE-5012): break apart mongosh integration tests #3546

merged 14 commits into from
Feb 7, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jan 30, 2023 •
edited
Loading

Description

What is changing?

This PR breaks apart the mongosh integration task PR in CI.

specifically

  • the mongosh integration test task is now broken into three categories of tasks. there is a task that compiles mongosh, there are a number of tasks that test various mongosh packages (these packages depend on the driver), and there is a new manual test task that asserts that there are no new mongosh tasks that we need to consider
Is there new documentation needed for these changes?

No.

What is the motivation for this change?

More easily digestible output from the mongosh tasks in CI.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken added the Blocked Blocked on other work label Jan 30, 2023
@baileympearson baileympearson mentioned this pull request Jan 31, 2023
Merged
addaleax
addaleax reviewed Jan 31, 2023
View reviewed changes
.evergreen/install-and-bootstrap-mongosh.sh Outdated Show resolved Hide resolved
.evergreen/generate_mongosh_tasks.js Outdated Show resolved Hide resolved
@baileympearson baileympearson changed the title WIP DO NOT MERGE chore: use subprocess exec ci: break apart mongosh integration tests Feb 2, 2023
@baileympearson baileympearson marked this pull request as ready for review February 2, 2023 23:03
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 3, 2023
durran
durran requested changes Feb 3, 2023
View reviewed changes
.evergreen/generate_evergreen_tasks.js Outdated Show resolved Hide resolved
.evergreen/run-mongosh-integration-tests.sh Outdated Show resolved Hide resolved
.evergreen/run-mongosh-scope-test.sh Outdated Show resolved Hide resolved
test/readme.md Outdated Show resolved Hide resolved
test/readme.md Outdated Show resolved Hide resolved
@durran durran removed the Blocked Blocked on other work label Feb 3, 2023
baileympearson and others added 2 commits February 3, 2023 10:35
@baileympearson @durran
Update test/readme.md
55bda11 
Co-authored-by: Durran Jordan <[email protected]>
@baileympearson @durran
Update test/readme.md
32ad61c 
Co-authored-by: Durran Jordan <[email protected]>
addaleax
addaleax reviewed Feb 3, 2023
View reviewed changes
.evergreen/generate_mongosh_tasks.js Outdated Show resolved Hide resolved
test/manual/mongosh_scopes.test.ts Show resolved Hide resolved
@baileympearson
Copy link
Contributor Author

@durran I also backported Neal's windows build fix into this PR. I can break it out into a separate PR if you would prefer

@baileympearson baileympearson requested a review from durran February 6, 2023 13:52
durran
durran previously approved these changes Feb 6, 2023
View reviewed changes
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 6, 2023
@durran durran changed the title ci: break apart mongosh integration tests ci(NODE-5010): break apart mongosh integration tests Feb 6, 2023
@durran durran changed the title ci(NODE-5010): break apart mongosh integration tests ci(NODE-5012): break apart mongosh integration tests Feb 6, 2023
@durran durran merged commit 6a906fc into mongodb:4.x Feb 7, 2023
baileympearson added a commit that referenced this pull request Feb 7, 2023
@baileympearson @durran @nbbeeken
ci(NODE-5012): break apart mongosh integration tests (#3546)
448a768 
Co-authored-by: Durran Jordan <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
@baileympearson baileympearson mentioned this pull request Feb 8, 2023
Merged
5 tasks
baileympearson added a commit that referenced this pull request Feb 9, 2023
@baileympearson @durran @nbbeeken
ci(NODE-5012): break apart mongosh integration tests (#3546)
3a7b32a 
Co-authored-by: Durran Jordan <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
durran added a commit that referenced this pull request Feb 10, 2023
@baileympearson @durran @nbbeeken
ci(NODE-5012): break apart mongosh integration tests (#3546) (#3559)
4fdd257 
Co-authored-by: Durran Jordan <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baileympearson @durran @addaleax @nbbeeken