-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-108667: Get all the private endpoints for the Data Lake in the specified project. #917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just don't forget to plan for e2e testing
@@ -21,7 +21,7 @@ require ( | |||
github.com/spf13/viper v1.10.1 | |||
github.com/stretchr/testify v1.7.0 | |||
github.com/tangzero/inflector v1.0.0 | |||
go.mongodb.org/atlas v0.14.0 | |||
go.mongodb.org/atlas v0.14.1-0.20220104180936-6afea6036494 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what would be the difference between v0.14.1-0.20220104180936-6afea6036494
and v0.14.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you go here MongoDB Atlas Client Release v0.14.0, you see that this release doesn’t have 4 commits from master
In particular, the one that we are using here is mongodb/go-client-mongodb-atlas#271 which isn’t in v0.14.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, so it's a kind of pre-release for v0.14.1
. My comment is non-blocking btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (second restamping, on Melissa's behalf -- reviewed by Melissa M).
Addressed Comments
Proposed changes
Jira ticket: CLOUDP-108667
Checklist
make fmt
and formatted my codeFurther comments
./bin/mongocli atlas privateendpoint dataLakes aws ls ID ENDPOINT PROVIDER TYPE COMMENT vpce-0fcd9d80bbafe1607 AWS DATA_LAKE test mongocli