Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-108667: Get all the private endpoints for the Data Lake in the specified project. #917

Merged
merged 6 commits into from
Jan 13, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jan 11, 2022

Proposed changes

Jira ticket: CLOUDP-108667

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if a new command or e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli atlas privateendpoint dataLakes aws ls
ID                       ENDPOINT PROVIDER   TYPE        COMMENT
vpce-0fcd9d80bbafe1607   AWS                 DATA_LAKE   test mongocli
~/workspace/mongocli git:(CLOUDP-108667) ✗ ./bin/mongocli atlas privateendpoint dataLakes aws ls -o json
{
  "links": [
    {
      "rel": "self",
      "href": "https://cloud-dev.mongodb.com/api/atlas/v1.0/groups/5e4e593f70dfbf1010295836/privateNetworkSettings/endpointIds?pageNum=1\u0026itemsPerPage=100"
    }
  ],
  "results": [
    {
      "endpointId": "vpce-0fcd9d80bbafe1607",
      "provider": "AWS",
      "type": "DATA_LAKE"
    }
  ],
  "totalCount": 1
}

@andreaangiolillo andreaangiolillo marked this pull request as ready for review January 12, 2022 12:38
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner January 12, 2022 12:38
@andreaangiolillo andreaangiolillo requested review from a team and johansteyn January 12, 2022 12:38
gssbzn
gssbzn previously approved these changes Jan 12, 2022
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just don't forget to plan for e2e testing

@@ -21,7 +21,7 @@ require (
github.com/spf13/viper v1.10.1
github.com/stretchr/testify v1.7.0
github.com/tangzero/inflector v1.0.0
go.mongodb.org/atlas v0.14.0
go.mongodb.org/atlas v0.14.1-0.20220104180936-6afea6036494
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what would be the difference between v0.14.1-0.20220104180936-6afea6036494 and v0.14.1?

Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you go here MongoDB Atlas Client Release v0.14.0, you see that this release doesn’t have 4 commits from master
Screenshot 2022-01-12 at 15 55 25

In particular, the one that we are using here is mongodb/go-client-mongodb-atlas#271 which isn’t in v0.14.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, so it's a kind of pre-release for v0.14.1. My comment is non-blocking btw.

Copy link
Contributor

@melissamahoney-mongodb melissamahoney-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes :)

internal/cli/atlas/privateendpoints/datalake/aws/list.go Outdated Show resolved Hide resolved
internal/cli/atlas/privateendpoints/datalake/aws/aws.go Outdated Show resolved Hide resolved
internal/cli/atlas/privateendpoints/datalake/data_lake.go Outdated Show resolved Hide resolved
@JuliaMongo JuliaMongo self-requested a review January 13, 2022 14:35
Copy link
Contributor

@JuliaMongo JuliaMongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (second restamping, on Melissa's behalf -- reviewed by Melissa M).

@andreaangiolillo andreaangiolillo removed the request for review from melissamahoney-mongodb January 13, 2022 14:40
@andreaangiolillo andreaangiolillo merged commit 53b6e8d into master Jan 13, 2022
@andreaangiolillo andreaangiolillo deleted the CLOUDP-108667 branch January 13, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants