INTMDB-263: Added Private_link_endpoint_adl resource to go-client #271
Conversation
| // PrivateLinkEndpointsADLService is an interface for interfacing with the Private Link Endpoints ADL | ||
| // of the MongoDB Atlas API datalake and online archive. | ||
| // | ||
| // See more: https://docs.atlas.mongodb.com/reference/api/private-endpoints/ |
There was a problem hiding this comment.
this link is not correct which leads me to a major issue here.
Given this statement about the go client lib README
The services of a client divide the API into logical chunks and correspond to
the structure of the Atlas API documentation at
https://docs.atlas.mongodb.com/api/.
You have two options
Add the methods to OnlineArchiveService (https://docs.atlas.mongodb.com/reference/api/online-archive/)
Or add the methods to DataLakeService (https://docs.mongodb.com/datalake/reference/api/datalakes-api/)
Even adding to both may be the correct thing
There was a problem hiding this comment.
my bad, I copy from private_link but I forgot to change this
There was a problem hiding this comment.
Thanks for updating the link but that doesn't solve my main comment, let's not add a new service, let's add the method to OnlineArchiveService, DataLakeService or both
There was a problem hiding this comment.
Oh I understand, but now my concern is, it is okay to use DataLakeService when you are using OnlineArchiveService and want to create a private_link?
There was a problem hiding this comment.
What happen if the API documentation for the private_link_endpoint for this gets a new section? you will need to "refactor" this services?
There was a problem hiding this comment.
is it okay to use DataLakeService when you are using OnlineArchiveService and want to create a private_link?
I say yes but up to you, remember one of the options is to add to both
What happen if the API documentation for the private_link_endpoint for this gets a new section?
We have a "no breaking changes" approach on the client unless strictly necessary, if the docs are moved around we should not move code around, we'll live with the choices made with what we knew today
There was a problem hiding this comment.
Ready! I added this new methods on both datalake and online archive services
|
@gssbzn I cannot merge due my access level, can you merge it, please? |
Description
Added
PrivateLinkEndpointADLresource to go-client to manage DataLake and Online Archive private link endpointsLink to any related issue(s): INTMDB-263
Type of change:
Required Checklist:
make fmtand formatted my codeFurther comments