Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-234527: Remove MongoCLI 3rd followup #2716

Merged
merged 8 commits into from
Mar 6, 2024
Merged

CLOUDP-234527: Remove MongoCLI 3rd followup #2716

merged 8 commits into from
Mar 6, 2024

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Mar 6, 2024 •
edited
Loading

Proposed changes

Remove MongoCLI (followup from #2706), cleaning up store

Jira ticket: CLOUDP-234527

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes changed the title CLOUDP 234527 followup3 CLOUDP-234527 Remove MongoCLI 3rd followup Mar 6, 2024
@fmenezes fmenezes marked this pull request as ready for review March 6, 2024 09:42
@fmenezes fmenezes requested a review from a team March 6, 2024 09:42
@gssbzn gssbzn changed the title CLOUDP-234527 Remove MongoCLI 3rd followup CLOUDP-234527: Remove MongoCLI 3rd followup Mar 6, 2024
@fmenezes fmenezes requested a review from a team March 6, 2024 09:50
@fmenezes fmenezes mentioned this pull request Mar 6, 2024
Merged
gssbzn
gssbzn reviewed Mar 6, 2024
View reviewed changes
internal/cli/atlas/deployments/options/deployment_opts_pre_run.go Show resolved Hide resolved
internal/cli/performance_advisor_opts.go Outdated Show resolved Hide resolved
internal/kubernetes/operator/install.go Outdated Show resolved Hide resolved
internal/prompt/config.go Outdated Show resolved Hide resolved
internal/store/service_version.go Outdated Show resolved Hide resolved
@fmenezes fmenezes requested a review from gssbzn March 6, 2024 10:11
gssbzn
gssbzn reviewed Mar 6, 2024
View reviewed changes
go.mod
@@ -43,7 +43,6 @@ require (
go.mongodb.org/atlas v0.36.0
go.mongodb.org/atlas-sdk/v20231115007 v20231115007.1.0
go.mongodb.org/mongo-driver v1.14.0
go.mongodb.org/ops-manager v0.55.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

gssbzn
gssbzn previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit be8aaae into master Mar 6, 2024
18 of 20 checks passed
@fmenezes fmenezes deleted the CLOUDP-234527_followup3 branch March 6, 2024 10:34
@fmenezes fmenezes mentioned this pull request Mar 7, 2024
Merged
6 tasks
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmenezes @gssbzn