Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: clean some usages of the old sdk #2711

Merged
merged 2 commits into from
Mar 6, 2024
Merged

task: clean some usages of the old sdk #2711

merged 2 commits into from
Mar 6, 2024

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Mar 5, 2024

Fix some old usages of the deprecated SDK

@gssbzn gssbzn marked this pull request as ready for review March 6, 2024 08:55
@gssbzn gssbzn requested a review from a team March 6, 2024 08:55
fmenezes
fmenezes requested changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@fmenezes fmenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me but let's merge #2716 first given some of these files are being clean up already

@gssbzn gssbzn requested a review from fmenezes March 6, 2024 10:51
@gssbzn gssbzn merged commit c94d94d into master Mar 6, 2024
20 checks passed
@gssbzn gssbzn deleted the clean-old-sdk-usages branch March 6, 2024 11:00
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmenezes fmenezes fmenezes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gssbzn @fmenezes