-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-234527 Remove mongocli #2688
Conversation
README.md
Outdated
@@ -1,22 +1,72 @@ | |||
## MongoDB Atlas CLI | |||
# Atlas CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Atlas CLI | |
## MongoDB Atlas CLI |
You forgot to update this file:
|
Forgotten linux notarize file:
|
|
|
mongodb-atlas-cli/build/ci/release.yml Line 72 in 18262de
|
Not sure about this one, might be shared: mongodb-atlas-cli/build/ci/release.yml Line 80 in 18262de
|
Not 100%, but I think this is not needed for atlascli mongodb-atlas-cli/build/ci/evergreen.yml Line 174 in 18262de
|
@jeroenvervaeke we should both remove
it's a clean up gap from #2558 |
this one is actually used, we can copy config from mongocli to atlascli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Remove mongocli
Jira ticket: CLOUDP-234527
Checklist
make fmt
and formatted my codeFurther comments