Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-234527 Remove mongocli #2688

Merged
merged 16 commits into from
Mar 4, 2024
Merged

CLOUDP-234527 Remove mongocli #2688

merged 16 commits into from
Mar 4, 2024

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Mar 1, 2024

Proposed changes

Remove mongocli

Jira ticket: CLOUDP-234527

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes marked this pull request as ready for review March 1, 2024 17:45
@fmenezes fmenezes requested a review from a team as a code owner March 1, 2024 17:45
@fmenezes fmenezes requested a review from a team March 1, 2024 17:45
README.md Outdated
@@ -1,22 +1,72 @@
## MongoDB Atlas CLI
# Atlas CLI
Copy link
Collaborator

@gssbzn gssbzn Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Atlas CLI
## MongoDB Atlas CLI

@jeroenvervaeke
Copy link
Collaborator

You forgot to update this file:

if [[ "${TOOL_NAME:?}" == atlascli ]]; then

@jeroenvervaeke
Copy link
Collaborator

Forgotten linux notarize file:

if [ "${TOOL_NAME}" == "atlascli" ]; then

@jeroenvervaeke
Copy link
Collaborator

if [[ "${tool_name-}" == "atlascli" ]]; then

@jeroenvervaeke
Copy link
Collaborator

if [[ "${TOOL_NAME:?}" == atlascli ]]; then

@jeroenvervaeke
Copy link
Collaborator

NOTARY_SIGNING_KEY_MONGOCLI: ${notary_service_signing_key_mongocli}

@jeroenvervaeke
Copy link
Collaborator

Not sure about this one, might be shared:

GRS_USERNAME_MONGOCLI: ${garasign_username_mongocli}

@jeroenvervaeke
Copy link
Collaborator

Not 100%, but I think this is not needed for atlascli

@fmenezes
Copy link
Collaborator Author

fmenezes commented Mar 4, 2024

NOTARY_SIGNING_KEY_MONGOCLI: ${notary_service_signing_key_mongocli}

@jeroenvervaeke we should both remove

  • NOTARY_SIGNING_KEY_ATLASCLI
  • NOTARY_SIGNING_KEY_MONGOCLI
  • NOTARY_SIGNING_COMMENT
  • NOTARY_AUTH_TOKEN
  • NOTARY_URL

it's a clean up gap from #2558

@fmenezes
Copy link
Collaborator Author

fmenezes commented Mar 4, 2024

Not 100%, but I think this is not needed for atlascli

this one is actually used, we can copy config from mongocli to atlascli

jeroenvervaeke
jeroenvervaeke previously approved these changes Mar 4, 2024
Copy link
Collaborator

@jeroenvervaeke jeroenvervaeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RELEASING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@tibulca tibulca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit 5dbb0a9 into master Mar 4, 2024
19 checks passed
@fmenezes fmenezes deleted the CLOUDP-234527 branch March 4, 2024 14:13
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants