Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-177522 Move cli signing to garasign #2558

Merged
merged 18 commits into from
Jan 25, 2024
Merged

CLOUDP-177522 Move cli signing to garasign #2558

merged 18 commits into from
Jan 25, 2024

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Jan 17, 2024 •
edited
Loading

Proposed changes

Move cli signing to garasign

Jira ticket: CLOUDP-177522

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

⚠️ potential regressions might happen on release, currently the only way to tell is during the next release of mongocli and atlascli ⚠️

blva
blva reviewed Jan 18, 2024
View reviewed changes
build/package/mongocli_windows_notarize.sh Outdated
@@ -20,5 +20,12 @@ FILE="dist/windows_windows_amd64_v1/bin/mongocli.exe"
if [[ -f "$FILE" ]]; then
echo "notarizing windows binaries"
export NOTARY_SIGNING_KEY=$NOTARY_SIGNING_KEY_MONGOCLI
go run ./tools/sign -file "$FILE"
podman run \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reasons to use podman instead of docker here? if we haven't faced issues in the past w/ this, I'm afraid how many flaky failures we would see here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to licensing, docker is paid so we need to use a free product

@fmenezes fmenezes marked this pull request as ready for review January 24, 2024 19:04
@fmenezes fmenezes requested a review from a team January 24, 2024 19:04
@fmenezes fmenezes merged commit 0abff75 into master Jan 25, 2024
16 of 18 checks passed
@fmenezes fmenezes deleted the CLOUDP-177522 branch January 25, 2024 12:58
@fmenezes fmenezes mentioned this pull request Mar 4, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blva blva blva left review comments

@tibulca tibulca tibulca left review comments

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmenezes @gssbzn @tibulca @blva