Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-3686 Consolidate CodecOptions Typings #1199

Merged
merged 6 commits into from
Apr 28, 2023
Merged

PYTHON-3686 Consolidate CodecOptions Typings #1199

merged 6 commits into from
Apr 28, 2023

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from ShaneHarvey as a code owner April 28, 2023 20:06
ShaneHarvey
ShaneHarvey approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I know why the --strict tests are failing, I'll add that back after we merge #1196 and #1194.

@blink1073 blink1073 merged commit e75cfec into mongodb:master Apr 28, 2023
@blink1073 blink1073 deleted the PYTHON-3686 branch April 28, 2023 21:11
@ShaneHarvey ShaneHarvey mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @ShaneHarvey