Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-3686 Pin mypy dependencies, don't upgrade pip #1198

Closed
wants to merge 5 commits into from

Conversation

ShaneHarvey
Copy link
Member

No description provided.

@ShaneHarvey
Copy link
Member Author

Wow, pinning to pip 23.0.1 fixes the errors on Python 3.7.

@ShaneHarvey
Copy link
Member Author

ShaneHarvey commented Apr 28, 2023

Oh I bet if this is related to pip's build via wheel by default change. My theory is that we mistakenly don't ship the codec_options.pyi file in the wheel.

@blink1073
Copy link
Member

Better to be explicit and add recursive-include bson *.pyi to MANIFEST.in either way.

@ShaneHarvey
Copy link
Member Author

I'll try, I do see that codec_options.pyi is already included in the wheel so I don't think it's that simple.

@ShaneHarvey
Copy link
Member Author

ShaneHarvey commented Apr 28, 2023

Fixed by #1199

It turns out that there's some bug/incompatibility with stub files when pymongo is installed with the latest versions of pip. To workaround this issue we merged the stub file logic into codec_options.py.

@ShaneHarvey ShaneHarvey deleted the PYTHON-3686 branch April 28, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants