GODRIVER-1963 remove dropDatabase result #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
reviewed
May 3, 2021
| // Execute runs this operations and returns an error if the operaiton did not execute successfully. | ||
| func (dd *DropDatabase) Execute(ctx context.Context) error { | ||
| if dd.deployment == nil { | ||
| return errors.New("the DropDatabase operation must have a Deployment set before Execute can be called") | ||
| } | ||
|
|
||
| return driver.Operation{ | ||
| CommandFn: dd.command, | ||
| ProcessResponseFn: dd.processResponse, |
There was a problem hiding this comment.
What happens if there's an error from DropDatabase()? Will the error not be returned now that there's no passed-in ProcessResponseFn when creating/executing the Operation?
There was a problem hiding this comment.
No, the only errors that ProcessResponseFn pass back are errors for the actual processing. Operation.decodeResult will separate out server errors before that, and those will get returned
There was a problem hiding this comment.
Ah that makes sense. Sounds good!
benjirewis
approved these changes
May 3, 2021
| // Execute runs this operations and returns an error if the operaiton did not execute successfully. | ||
| func (dd *DropDatabase) Execute(ctx context.Context) error { | ||
| if dd.deployment == nil { | ||
| return errors.New("the DropDatabase operation must have a Deployment set before Execute can be called") | ||
| } | ||
|
|
||
| return driver.Operation{ | ||
| CommandFn: dd.command, | ||
| ProcessResponseFn: dd.processResponse, |
There was a problem hiding this comment.
Ah that makes sense. Sounds good!
kevinAlbs
approved these changes
May 11, 2021
stlimtat
pushed a commit
to stlimtat/mongo-go-driver
that referenced
this pull request
May 17, 2021
* 'master' of https://github.com/mongodb/mongo-go-driver: (39 commits) GODRIVER-2004 Add Versioned API connection examples for Docs (mongodb#665) GODRIVER-1961 Run OCSP tests against RHEL 7.0 (mongodb#664) GODRIVER-1844 finer precision for getSecondsSinceEpoch (mongodb#666) GODRIVER-1973 create internal copy of aws v4 signing code (mongodb#657) GODRIVER-1951 Update the Go version for Evergreen builds to 1.16 (mongodb#663) GODRIVER-1949 add more ignored killAllSessions errors for unified tes… (mongodb#658) GODRIVER-1963 remove dropDatabase result (mongodb#660) GODRIVER-1180 Remove legacy transform functions from mongo (mongodb#583) GODRIVER-1937 Update legacy ListCollections to support the BatchSize option for server version 2.6 (mongodb#656) GODRIVER-1933 remove xtrace from shell scripts (mongodb#661) fix README error handling of FindOne (mongodb#636) GODRIVER-1938 update mongocryptd serverSelectionTimeout to 10 seconds (mongodb#659) GODRIVER-1925 Surface cursor errors in DownloadStream fillBuffer (mongodb#653) GODRIVER-1955 create labeledError interface (mongodb#651) GODRIVER-1947 Unmarshal unicode surrogate pairs correctly in UnmarshalExtJSON. (mongodb#649) Changed order of actions in ObjectIDFromHex func (mongodb#637) GODRIVER-1750 Ensure contexts are always cancelled during server monitoring (mongodb#654) GODRIVER-1931 Sync new cursors and SDAM LB tests (mongodb#655) GODRIVER-1981 Sync new transactions tests (mongodb#652) GODRIVER-1931 Run tests against LBs in Evergreen (mongodb#648) ...
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.