GODRIVER-1937 Update legacy ListCollections to support the BatchSize option for server version 2.6 #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
requested review from
kevinAlbs,
iwysiu,
divjotarora and
benjirewis
…option for server version 2.6
matthewdale
force-pushed
the
godriver1937-fix-legacy-batchsize
branch
from
72b1ea7 to
dcf9c12
Compare
iwysiu
reviewed
Apr 29, 2021
divjotarora
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Thanks for investigating this and putting up a fix quickly! I echo all of @iwysiu's comments so LGTM assuming you address those.
benjirewis
approved these changes
Apr 30, 2021
kevinAlbs
approved these changes
May 3, 2021
…necessary 2.6 min server version check.
matthewdale
commented
May 4, 2021
There was a problem hiding this comment.
@iwysiu I can't seem to respond to your other comment about min server version in this review now that I've updated the code, but I've removed the unnecessary 2.6 min server version check.
iwysiu
reviewed
May 4, 2021
There was a problem hiding this comment.
@matthewdale Mostly looks good with a couple nits!
Not sure if you saw the comment on my last review about trying to run the "batch size" test on line 224 on server version 2.6 too. Since that test specifically checks that "batchSize" gets sent, it makes sense to me to try to include it
iwysiu
approved these changes
May 4, 2021
matthewdale
added a commit
that referenced
this pull request
May 5, 2021
…option for server version 2.6 (#656)
stlimtat
pushed a commit
to stlimtat/mongo-go-driver
that referenced
this pull request
May 17, 2021
* 'master' of https://github.com/mongodb/mongo-go-driver: (39 commits) GODRIVER-2004 Add Versioned API connection examples for Docs (mongodb#665) GODRIVER-1961 Run OCSP tests against RHEL 7.0 (mongodb#664) GODRIVER-1844 finer precision for getSecondsSinceEpoch (mongodb#666) GODRIVER-1973 create internal copy of aws v4 signing code (mongodb#657) GODRIVER-1951 Update the Go version for Evergreen builds to 1.16 (mongodb#663) GODRIVER-1949 add more ignored killAllSessions errors for unified tes… (mongodb#658) GODRIVER-1963 remove dropDatabase result (mongodb#660) GODRIVER-1180 Remove legacy transform functions from mongo (mongodb#583) GODRIVER-1937 Update legacy ListCollections to support the BatchSize option for server version 2.6 (mongodb#656) GODRIVER-1933 remove xtrace from shell scripts (mongodb#661) fix README error handling of FindOne (mongodb#636) GODRIVER-1938 update mongocryptd serverSelectionTimeout to 10 seconds (mongodb#659) GODRIVER-1925 Surface cursor errors in DownloadStream fillBuffer (mongodb#653) GODRIVER-1955 create labeledError interface (mongodb#651) GODRIVER-1947 Unmarshal unicode surrogate pairs correctly in UnmarshalExtJSON. (mongodb#649) Changed order of actions in ObjectIDFromHex func (mongodb#637) GODRIVER-1750 Ensure contexts are always cancelled during server monitoring (mongodb#654) GODRIVER-1931 Sync new cursors and SDAM LB tests (mongodb#655) GODRIVER-1981 Sync new transactions tests (mongodb#652) GODRIVER-1931 Run tests against LBs in Evergreen (mongodb#648) ...
tsedgwick
pushed a commit
to mongodb-forks/mongo-go-driver
that referenced
this pull request
May 27, 2021
…option for server version 2.6 (mongodb#656)
tsedgwick
pushed a commit
to mongodb-forks/mongo-go-driver
that referenced
this pull request
Jun 1, 2021
…option for server version 2.6 (mongodb#656)
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
…option for server version 2.6 (mongodb#656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the
BatchSizeoption for theListCollectionscall for server version 2.6Changes:
cursor.batchSizefield to set theNumberToReturnin the legacy list collections command for server version 2.6