-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-38679 mongoexport consistency consideration #166
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d21cc93
DOCSP-38679 mongoexport consistency consideration
ltran-mdb2 9c9940d
DOCSP-38679 mongoexport consistency consideration
ltran-mdb2 8c47e9c
DOCSP-38679 copy edit
ltran-mdb2 e69b673
DOCSP-38679 tech edits:
ltran-mdb2 6c5f937
DOCSP-38679 tech edits:
ltran-mdb2 2d98bfe
DOCSP-38679 tech edits:
ltran-mdb2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we instead advise users to pause all writes and turn off balancers? Certain operations may use transactions implicitly under the hood. There could also be race conditions between turning off writes and finishing any in-flight operations, so users should make certain that the cluster has fully quiesced before attempting any snapshots. Ditto this comment for mongoexport as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ltran-mdb2 just wanted to follow-up on this. Let me know if this needs a separate ticket - thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mvankeulen94 , sorry for the delay! Could you create a separate ticket for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed https://jira.mongodb.org/browse/DOCSP-41895, thank you! Please feel free to reassign if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally rather than having this blurb here, we could instead restate the disclaimer that these tools are not intended for taking backups, and to see https://www.mongodb.com/docs/manual/administration/backup-sharded-clusters/ for how to back up sharded clusters.