Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-38679 mongoexport consistency consideration #166

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Jul 17, 2024

DESCRIPTION

recommend users pause operations on sharded clusters during export

STAGING

https://preview-mongodbltranmdb2.gatsbyjs.io/database-tools/DOCSP-38679/mongoexport/
https://preview-mongodbltranmdb2.gatsbyjs.io/database-tools/DOCSP-38679/mongodump/

JIRA

https://jira.mongodb.org/browse/DOCSP-38679

BUILD LOG

https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=669818eb26eba79552d02c08

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link
Collaborator

@mmaville-mdb mmaville-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one small punctuation nit. LGTM!

.. note::

To avoid data inconsistencies, pause the following actions on your
sharded cluster when you run ``mongoexport``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sharded cluster when you run ``mongoexport``.
sharded cluster when you run ``mongoexport``:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Thank you!

Copy link

@jddubois jddubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@dsahni dsahni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks lgtm

@sarah-olson-mongodb sarah-olson-mongodb merged commit 2391da0 into mongodb:master Jul 22, 2024
- Cross-shard transactions
- Data definition language operations (operations that create and modify
collections)
- Chunk balancing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we instead advise users to pause all writes and turn off balancers? Certain operations may use transactions implicitly under the hood. There could also be race conditions between turning off writes and finishing any in-flight operations, so users should make certain that the cluster has fully quiesced before attempting any snapshots. Ditto this comment for mongoexport as well

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ltran-mdb2 just wanted to follow-up on this. Let me know if this needs a separate ticket - thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mvankeulen94 , sorry for the delay! Could you create a separate ticket for this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed https://jira.mongodb.org/browse/DOCSP-41895, thank you! Please feel free to reassign if needed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally rather than having this blurb here, we could instead restate the disclaimer that these tools are not intended for taking backups, and to see https://www.mongodb.com/docs/manual/administration/backup-sharded-clusters/ for how to back up sharded clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants