-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-38679 mongoexport consistency consideration #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one small punctuation nit. LGTM!
source/mongoexport.txt
Outdated
.. note:: | ||
|
||
To avoid data inconsistencies, pause the following actions on your | ||
sharded cluster when you run ``mongoexport``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sharded cluster when you run ``mongoexport``. | |
sharded cluster when you run ``mongoexport``: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks lgtm
- Cross-shard transactions | ||
- Data definition language operations (operations that create and modify | ||
collections) | ||
- Chunk balancing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we instead advise users to pause all writes and turn off balancers? Certain operations may use transactions implicitly under the hood. There could also be race conditions between turning off writes and finishing any in-flight operations, so users should make certain that the cluster has fully quiesced before attempting any snapshots. Ditto this comment for mongoexport as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ltran-mdb2 just wanted to follow-up on this. Let me know if this needs a separate ticket - thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mvankeulen94 , sorry for the delay! Could you create a separate ticket for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed https://jira.mongodb.org/browse/DOCSP-41895, thank you! Please feel free to reassign if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally rather than having this blurb here, we could instead restate the disclaimer that these tools are not intended for taking backups, and to see https://www.mongodb.com/docs/manual/administration/backup-sharded-clusters/ for how to back up sharded clusters.
DESCRIPTION
recommend users pause operations on sharded clusters during export
STAGING
https://preview-mongodbltranmdb2.gatsbyjs.io/database-tools/DOCSP-38679/mongoexport/
https://preview-mongodbltranmdb2.gatsbyjs.io/database-tools/DOCSP-38679/mongodump/
JIRA
https://jira.mongodb.org/browse/DOCSP-38679
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=669818eb26eba79552d02c08
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?