feat(query-parser): allow falsy indentation, default to 2 space in toJSString, deprecate stringify #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of https://jira.mongodb.org/browse/COMPASS-6980 we need to make Compass not use
stringify
for query parsing so that we can retain multi-spaces in values. We also want to have more flexibility over how we indent those places. This pr adds that flexibility and a deprecated notice onstringify
so hopefully we can avoid using it in future.To see a quick example of the bug
stringify
usage causes in Compass, run a query with the following:And then click on it in query history and observe the multiple spaces in
te st
are replaced by one space.