fix(query-bar, schema): double space not applied from schema or query history COMPASS-6980 #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
approved these changes
Feb 21, 2024
| typeof _value === 'undefined' ? '' : toJSString(_value, 0) || ''; | ||
|
|
||
| valueAsString = prettify(valueAsString, 'javascript-expression', { | ||
| trailingComma: 'none', |
There was a problem hiding this comment.
I really wouldn't mind if we make this default in Compass, definitely would prefer it to the need to have different configurations in different parts of the app 🙂
There was a problem hiding this comment.
Agreed, going to mention in the slack channel, I'll do that in a separate pr if folks are on board. Thanks for mentioning!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-6980
Pulls in mongodb-js/devtools-shared#235 To see a quick example of the bug
stringifyusage causes in Compass, run a query with the following:And then click on it in query history and observe the multiple spaces in
te stare replaced by one space.You can also insert a document with that value and click on it in the
schematab and see the wrong value was inserted previously (fixed in these changes).These changes also make it so we prettify queries applied from the query bar and schema clicks.