Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): automatically create db user and add ip address to the access list before running tests #6432

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

gribnoysup
Copy link
Collaborator

Another follow-up to cloud e2e tests to reduce the amount of manual config required to run these:

  • Create db user automatically and delete it afterwards
  • Automatically add current ip to the network access

Both are added with an arbitrary delete after of two hours that should be more than enough for our tests so that even if for some reason exit cleanup fails, they'd be eventually removed from the project

@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 1, 2024
Comment on lines +90 to +92
atlascli accessList create \
--currentIp \
--deleteAfter "$DELETE_AFTER"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mabaasit
Copy link
Contributor

mabaasit commented Nov 1, 2024

cloud setup keeps getting better!

@gribnoysup gribnoysup merged commit 1eef24e into main Nov 1, 2024
28 of 30 checks passed
@gribnoysup gribnoysup deleted the cloud-e2e-improvements-less-env-and-config branch November 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants