test(global-writes): add e2e tests COMPASS-8441 #6430
Conversation
| # | ||
| # When setting up for the first time, make sure you: | ||
| # - Add payment details to be able to create clusters. You can use stripe test card. | ||
| # - Allow network access to the project for your IP address. |
There was a problem hiding this comment.
Hah, just hit me that we can make this step unnecessary also with atlas cli (in this PR)
| @@ -46,6 +46,10 @@ | |||
| # | |||
| # (ATLAS_CLOUD_TEST_CLUSTER_NAME="TestCluster" source .evergreen/start-atlas-cloud-cluster.sh \ | |||
| # && npm run -w compass-e2e-tests test web -- --test-atlas-cloud-sandbox --test-filter="atlas-cloud/**/*") | |||
| # | |||
| # When setting up for the first time, make sure you: | |||
| # - Add payment details to be able to create clusters. You can use stripe test card. | |||
There was a problem hiding this comment.
Thanks for updating the documentation here! Can you move this to a more logical place where it would fit if you're doing these actions step by step? Probably either as part of creating a new org / project or as a step after it. The intention for the whole instruction above to be about setting up for the first time, so adding it as notes at the bottom of that is a bit weird 🙂
|
|
||
| it('should be able to shard an unsharded namespace and also unmanage it', async function () { | ||
| // Sharding a collection takes a bit longer | ||
| this.timeout(60_000); |
There was a problem hiding this comment.
This is smaller than our default timeout though
There was a problem hiding this comment.
actually bumped it for whole suite
| <div className={containerStyles}> | ||
| <div | ||
| className={containerStyles} | ||
| data-testid={`${shardingStatus.toLowerCase()}-status`} |
There was a problem hiding this comment.
I'd prefer something like data-status={status} and data-testid=global-writes-container - because status is more of a property of the workspace than an id (for example it could be generic NOT_READY). Alternatively the testid could be a combination of id and status
There was a problem hiding this comment.
data-status={status} reads better. i'll change it
|
By the way, I thought we'd do just one combined path to reduce the amount of setup, but it's not a must. |
| await browser.clickVisible(Selectors.GlobalWrites.UnmanageNamespaceButton); | ||
|
|
||
| // It transitions to the unmanaging state | ||
| await waitForGlobalWritesStatus(browser, 'UNSHARDED'); |
There was a problem hiding this comment.
note: this will be INCOMPLETE_SHARDING_SETUP after #6399, but it's quite likely that this will be merged first, so I'll update the test afterwards
There was a problem hiding this comment.
I might even add a test to check that the form is not present at this point, it's important that the key cannot be changed after unmanaging. But again, this hangs on my PR.
We are not doing multiple setup here, just running multiple test cases. We can also add test cases for other workflows here if needed. |
gribnoysup
force-pushed
the
COMPASS-8441-global0=-writes-tests
branch
from
8b3da4a to
94aca71
Compare
gribnoysup
force-pushed
the
COMPASS-8441-global0=-writes-tests
branch
from
94aca71 to
ad2a360
Compare
…om/mongodb-js/compass into COMPASS-8441-global0=-writes-tests
| @@ -1400,3 +1400,21 @@ export const ProxyCustomButton = | |||
|
|
|||
| // Close tab confirmation | |||
| export const ConfirmTabCloseModal = '[data-testid="confirm-tab-close"]'; | |||
|
|
|||
| export const GlobalWrites = { | |||
| tabStatus: (status: string) => `[data-status="${status.toLowerCase()}"]`, | |||
There was a problem hiding this comment.
Small nit: I think you might want to follow @paula-stacho advice here and add both data-testid as a special test selector in addition to the data-status, otherwise the selector you're building is a bit too vague about the context of selection (status of what?) which might make it hard to debug
…PASS-8441-global0=-writes-tests
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes