fix(hadron-document): allow expanding an element that has its type changed to array or object COMPASS-7929 #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged to array or object
gribnoysup
reviewed
Jul 11, 2024
gribnoysup
approved these changes
Jul 12, 2024
Comment on lines
471
to
473
| isValueExpandable(this.originalExpandableValue) || | ||
| (this.isModified() && | ||
| (this.currentType === 'Array' || this.currentType === 'Object')) |
There was a problem hiding this comment.
I know that this is just preserving existing code, but the more I look at it, the less sense it makes, sorry 😅 If you edited the element to a non-expandable type, changed Object to String say, this would still return true, which just doesn't sound right? Feels like the check you are adding instead, the one that looks at the currentType, is actually the best way to check for this instead of checking the value and is the only thing we need to check for, does this makes sense or is there a case I'm missing where looking at the original value is required?
There was a problem hiding this comment.
Good callout! Removed everything except the current type check.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-7929