feat(compass-crud): allows nested elements to also expand in steps #6009
Conversation
…hanges the visible elements
himanshusinghs
force-pushed
the
feat/nested-elements-step-expansion
branch
from
9fa0542 to
ea98771
Compare
| // In the editing mode we allow to show / hide less fields because | ||
| // historically Compass was doing this for "performance" reasons | ||
| step={editing ? 100 : 1000} | ||
| onSizeChange={setVisibleFieldsCount} | ||
| ></DocumentFieldsToggleGroup> | ||
| onSizeChange={handleVisibleFieldsChanged} |
There was a problem hiding this comment.
This is existing functionality, but I figured I'd bring it up here, no action needed. A small UX improvement here for folks with lots of fields in their documents could be to adjust the scroll position when they click to hide a lot of fields to the relative scroll height after the fields are hidden. Currently it's easy to lose a document if it's not the last document and you hide a bunch of fields.
There was a problem hiding this comment.
Yea I noticed this after I implemented virtual list. I will see what I can do there to modify this behaviour a little.
packages/compass-components/src/components/document-list/visible-field-toggle.tsx
Show resolved
Hide resolved
| data-testid="hide-fields-button" | ||
| > | ||
| Hide {hideSizeDiff} fields | ||
| </Button> | ||
| <Icon size="xsmall" glyph="ArrowUp"></Icon> |
There was a problem hiding this comment.
I think in the designs that Ben shared it was CaretDown / CaretUp, not an arrow. Don't have a strong preference, but arrow seems a big big when compared to the text near it, so maybe worth trying
There was a problem hiding this comment.
Thank you for pointing that out - I missed pulling that in, just did that.
Description
This patch introduces "Show more" fields toggle also on the nested elements which we earlier used to render with all of their children when expanded. With the change, we will the take a similar approach as that of Document, showing only a default number of elements to begin with(set to 25) which user can later change by clicking the toggle.
Screen.Recording.2024-07-12.at.09.35.40.mov
Designs for the toggle have also changed a bit as per Slack discussion:
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes