Revert "Make RPC server functions that read db thread safe" #8384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR #7937. Related to #8383.
Incorrect sequence that PR #7937 introduces:
This PR removes db read txn guards added in #7937 to the RPC server to avoid the above problem, accepting that the RPC API can still possibly return inconsistent data as the lesser of 2 evils (which is current behavior).
A stronger long term fix to ensure consistent chain state reads for RPC functions that will still return the latest data is preferred, with care to ensure a consistently ordered API across all sources (RPC / ZMQ / notifications etc.). See one such proposed solution here. (edited to clear up imprecise explanation)