Move DB lock guard to later stage #8383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@j-berman please review. |
It's important to take the DB lock after m_tx_pool lock when get_block_template RPC is run in parallel with a new block being added, otherwise it will return the old data.
SChernykh
force-pushed
the
fix_get_block_template
branch
from
031afb8 to
c280e41
Compare
|
I think this can be closed? We will instead revert the other patch for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important to take the DB lock after m_tx_pool lock when get_block_template RPC is run in parallel with a new block being added, otherwise it will return the old data.