-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cnspec panics when getting GitHub repo protection rules #289
Comments
Originially reported #287 (comment) and #287 (comment) by @benr and @scottford-io |
I cannot reproduce:
I build cnspec from latest main. |
@czunker can you try |
Also works:
|
I am not able to reproduce this @scottford-io @benr Can you retry with the latest cnspec to see if the issue is still there? |
@arlimus @chris-rock I just reproduced it on To reproduce, try scanning |
I tried it with
and it does not panic:
Also tried it with upstream, also does not panic:
@scottford-io Please give it a try with version 7.13.2. When it fails, please provide the command you used. |
@czunker it failed for me on
|
@czunker are you using an admin Personal Access Token with both |
Still no luck to reproduce this. I tried different scopes with classic tokens: All work for me. But I think you are on the right track with permissions. From the panic, something breaks while accessing the branch protection rules. As I'm not a member of the repo/org, I do not see any protection rules at all:
Perhaps, this looks different to you. @scottford-io Please double-check. But that was only the explanation for why I might not be able to reproduce this issue. Would it be possible to add me to the repo so that I can reproduce this? |
looking at the code it seems like maybe |
@czunker I just tested now with
|
Fixes #mondoohq/cnspec#289 Signed-off-by: Christian Zunker <[email protected]>
Fixes mondoohq/cnspec#289 Signed-off-by: Christian Zunker <[email protected]>
Describe the bug
To Reproduce
Run command above?
Expected behavior
Should error, but not panic.
Screenshots or CLI Output
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: